cloud-fan commented on a change in pull request #33576:
URL: https://github.com/apache/spark/pull/33576#discussion_r679638694
##########
File path:
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q5.sf100/explain.txt
##########
@@ -173,7 +173,7 @@ Input [5]: [s_store_id#23, sum#30, sum#31, sum#32, sum#33]
Keys [1]: [s_store_id#23]
Functions [4]: [sum(UnscaledValue(sales_price#8)),
sum(UnscaledValue(return_amt#10)), sum(UnscaledValue(profit#9)),
sum(UnscaledValue(net_loss#11))]
Aggregate Attributes [4]: [sum(UnscaledValue(sales_price#8))#35,
sum(UnscaledValue(return_amt#10))#36, sum(UnscaledValue(profit#9))#37,
sum(UnscaledValue(net_loss#11))#38]
-Results [5]: [MakeDecimal(sum(UnscaledValue(sales_price#8))#35,17,2) AS
sales#39, MakeDecimal(sum(UnscaledValue(return_amt#10))#36,17,2) AS RETURNS#40,
CheckOverflow((promote_precision(cast(MakeDecimal(sum(UnscaledValue(profit#9))#37,17,2)
as decimal(18,2))) -
promote_precision(cast(MakeDecimal(sum(UnscaledValue(net_loss#11))#38,17,2) as
decimal(18,2)))), DecimalType(18,2), true) AS profit#41, store channel AS
channel#42, concat(store, s_store_id#23) AS id#43]
+Results [5]: [MakeDecimal(sum(UnscaledValue(sales_price#8))#35,17,2) AS
sales#39, MakeDecimal(sum(UnscaledValue(return_amt#10))#36,17,2) AS returns#40,
CheckOverflow((promote_precision(cast(MakeDecimal(sum(UnscaledValue(profit#9))#37,17,2)
as decimal(18,2))) -
promote_precision(cast(MakeDecimal(sum(UnscaledValue(net_loss#11))#38,17,2) as
decimal(18,2)))), DecimalType(18,2), true) AS profit#41, store channel AS
channel#42, concat(store, s_store_id#23) AS id#43]
Review comment:
The outmost SELECT is ```
SELECT
channel,
id,
sum(sales) AS sales,
sum(returns) AS returns,
sum(profit) AS profit
```
The change makes sense
##########
File path:
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q5.sf100/explain.txt
##########
@@ -173,7 +173,7 @@ Input [5]: [s_store_id#23, sum#30, sum#31, sum#32, sum#33]
Keys [1]: [s_store_id#23]
Functions [4]: [sum(UnscaledValue(sales_price#8)),
sum(UnscaledValue(return_amt#10)), sum(UnscaledValue(profit#9)),
sum(UnscaledValue(net_loss#11))]
Aggregate Attributes [4]: [sum(UnscaledValue(sales_price#8))#35,
sum(UnscaledValue(return_amt#10))#36, sum(UnscaledValue(profit#9))#37,
sum(UnscaledValue(net_loss#11))#38]
-Results [5]: [MakeDecimal(sum(UnscaledValue(sales_price#8))#35,17,2) AS
sales#39, MakeDecimal(sum(UnscaledValue(return_amt#10))#36,17,2) AS RETURNS#40,
CheckOverflow((promote_precision(cast(MakeDecimal(sum(UnscaledValue(profit#9))#37,17,2)
as decimal(18,2))) -
promote_precision(cast(MakeDecimal(sum(UnscaledValue(net_loss#11))#38,17,2) as
decimal(18,2)))), DecimalType(18,2), true) AS profit#41, store channel AS
channel#42, concat(store, s_store_id#23) AS id#43]
+Results [5]: [MakeDecimal(sum(UnscaledValue(sales_price#8))#35,17,2) AS
sales#39, MakeDecimal(sum(UnscaledValue(return_amt#10))#36,17,2) AS returns#40,
CheckOverflow((promote_precision(cast(MakeDecimal(sum(UnscaledValue(profit#9))#37,17,2)
as decimal(18,2))) -
promote_precision(cast(MakeDecimal(sum(UnscaledValue(net_loss#11))#38,17,2) as
decimal(18,2)))), DecimalType(18,2), true) AS profit#41, store channel AS
channel#42, concat(store, s_store_id#23) AS id#43]
Review comment:
The outmost SELECT is
```
SELECT
channel,
id,
sum(sales) AS sales,
sum(returns) AS returns,
sum(profit) AS profit
```
The change makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
