cloud-fan commented on a change in pull request #33541:
URL: https://github.com/apache/spark/pull/33541#discussion_r679683101
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##########
@@ -249,13 +255,9 @@ object EnsureRequirements extends Rule[SparkPlan] {
}
def apply(plan: SparkPlan): SparkPlan = plan.transformUp {
- // TODO: remove this after we create a physical operator for
`RepartitionByExpression`.
- // SPARK-35989: AQE will change the partition number so we should retain
the REPARTITION_BY_NUM
- // shuffle which is specified by user. And also we can not remove
REBALANCE_PARTITIONS_BY_COL,
- // it is a special shuffle used to rebalance partitions.
- // So, here we only remove REPARTITION_BY_COL in AQE.
case operator @ ShuffleExchangeExec(upper: HashPartitioning, child,
shuffleOrigin)
- if shuffleOrigin == REPARTITION_BY_COL ||
!conf.adaptiveExecutionEnabled =>
+ if optimizeOutRepartition &&
+ (shuffleOrigin == REPARTITION_BY_COL || shuffleOrigin ==
REPARTITION_BY_NUM) =>
Review comment:
This may be good or not, but my change here is to revert back to the
behavior in 3.1, to make sure we don't have perf regression in 3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
