Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5919#discussion_r29713770
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -171,6 +171,11 @@ case class AttributeReference(
val exprId: ExprId = NamedExpression.newExprId,
val qualifiers: Seq[String] = Nil) extends Attribute with
trees.LeafNode[Expression] {
+ /**
+ * Returns true iff the expression id is the same for both attributes.
--- End diff --
I disagree. We use it iff a lot in SQL, and if you Google, the first thing
that comes up is "if and only if". Plus this is an internal comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
