attilapiros commented on a change in pull request #33550:
URL: https://github.com/apache/spark/pull/33550#discussion_r679945428
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -616,4 +603,6 @@ private[spark] object Config extends Logging {
val KUBERNETES_DRIVER_ENV_PREFIX = "spark.kubernetes.driverEnv."
val KUBERNETES_DNSNAME_MAX_LENGTH = 63
+ // The possible longest executor name would be "$prefix-exec-${Int.MaxValue}"
+ val KUBERNETES_POD_NAME_PREFIX_MAX_LENGTH = 63 - 6 -
Int.MaxValue.toString.length
Review comment:
Use the already existing val and explain the 6 a bit more like it was
`// 6 is length of '-exec-'`
```suggestion
val KUBERNETES_POD_NAME_PREFIX_MAX_LENGTH =
KUBERNETES_DNSNAME_MAX_LENGTH - 6 - Int.MaxValue.toString.length
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
