mridulm commented on pull request #33556: URL: https://github.com/apache/spark/pull/33556#issuecomment-889930635
In general, do not couple implementation details/expectations to general collections. If open() or flush() or close() can result in writes to the file, expectation of revert is to ensure this is discarded; if the code above evolves, we dont want to keep going down the stack to ensure correctness. Unless I am seeing a logical or performance issue to make this change, I would not make it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
