sunchao edited a comment on pull request #33584: URL: https://github.com/apache/spark/pull/33584#issuecomment-890074067
Thanks @huaxingao . > Currently, DSv2 partition filters and data filters are separated in PruneFileSourcePartitions. Should this be: "Currently, DSv2 partition filters and data filters are **not** separated in PruneFileSourcePartitions."? it also helps if you can put more context in the PR description, such as why partition filters are related to aggregate pushdown. In addition I'm wondering why this change is necessary: can we just separate partition and data filters inside `V2ScanRelationPushDown.pushDownAggregates`? for instance by doing something similar to `PruneFileSourcePartitions. getPartitionKeyFiltersAndDataFilters`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
