HyukjinKwon commented on a change in pull request #33591:
URL: https://github.com/apache/spark/pull/33591#discussion_r680431138
##########
File path: python/test_coverage/coverage_daemon.py
##########
@@ -17,26 +17,29 @@
import os
import imp
+import platform
# This is a hack to always refer the main code rather than built zip.
main_code_dir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
daemon = imp.load_source("daemon", "%s/pyspark/daemon.py" % main_code_dir)
if "COVERAGE_PROCESS_START" in os.environ:
- worker = imp.load_source("worker", "%s/pyspark/worker.py" % main_code_dir)
+ # PyPy with coverage makes the tests flaky, and CPython is enough for
coverage report.
+ if "pypy" not in platform.python_implementation().lower():
Review comment:
I think this is fine. the string comparison is already flaky given that
there might be other Python implementation or they might change the string
representation. Permissive comparison should be okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
