mridulm commented on a change in pull request #33034:
URL: https://github.com/apache/spark/pull/33034#discussion_r680612735
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -410,17 +500,42 @@ public MergeStatuses
finalizeShuffleMerge(FinalizeShuffleMerge msg) throws IOExc
+ "with the current attempt id %s stored in shuffle service for
application %s",
msg.appAttemptId, appShuffleInfo.attemptId, msg.appId));
}
- Map<Integer, AppShufflePartitionInfo> shufflePartitions =
- appShuffleInfo.partitions.remove(msg.shuffleId);
+ AtomicReference<Map<Integer, AppShufflePartitionInfo>>
shuffleMergePartitionsRef =
+ new AtomicReference<>(null);
+ // Metadata of the determinate stage shuffle can be safely removed as part
of finalizing
+ // shuffle merge. Currently once the shuffle is finalized for a
determinate stages, retry
+ // stages of the same shuffle will have shuffle push disabled.
+ if (msg.shuffleMergeId == DETERMINATE_SHUFFLE_MERGE_ID) {
+ AppShuffleMergePartitionsInfo appShuffleMergePartitionsInfo =
+ appShuffleInfo.shuffles.remove(msg.shuffleId);
+ if (appShuffleMergePartitionsInfo != null) {
+
shuffleMergePartitionsRef.set(appShuffleMergePartitionsInfo.shuffleMergePartitions);
+ }
+ } else {
+ appShuffleInfo.shuffles.compute(msg.shuffleId, (id, value) -> {
+ if (null == value || msg.shuffleMergeId != value.shuffleMergeId ||
Review comment:
When finalizing merge, if the incoming request is not for the current -
we should always throw exception - even if current is newer (or older).
The newer shuffle will have its own finalize later.
Given this, the `!=` condition would be correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
