itholic commented on a change in pull request #33581:
URL: https://github.com/apache/spark/pull/33581#discussion_r680639379
##########
File path: python/pyspark/pandas/data_type_ops/base.py
##########
@@ -314,9 +320,11 @@ def __or__(self, left: IndexOpsLike, right: Any) ->
SeriesOrIndex:
raise TypeError("Bitwise or can not be applied to %s." %
self.pretty_name)
def rand(self, left: IndexOpsLike, right: Any) -> SeriesOrIndex:
Review comment:
As @HyukjinKwon mentioned in
https://github.com/apache/spark/pull/33581/files#r680433058,
I think maybe we can just fix the typing from `right: Any` to something like
`right: Union[List, Tuple, Dict, Set]` rather adding function ?? (Or we can
take both typing and function ??)
I have no string opinion, too, but anyway the typing here `right: Any` seems
wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
