cloud-fan commented on a change in pull request #33413:
URL: https://github.com/apache/spark/pull/33413#discussion_r680646683
##########
File path:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala
##########
@@ -147,6 +147,21 @@ private[sql] class AvroDeserializer(
s"Avro logical type $other cannot be converted to SQL type
${TimestampType.sql}.")
}
+ case (LONG, TimestampNTZType) => avroType.getLogicalType match {
+ // For backward compatibility, if the Avro type is Long and it is not
logical type
Review comment:
then can we at least update the comment? it's no thing about backward
compatibility, but to keep consistent with TS LTZ.
##########
File path:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala
##########
@@ -147,6 +147,21 @@ private[sql] class AvroDeserializer(
s"Avro logical type $other cannot be converted to SQL type
${TimestampType.sql}.")
}
+ case (LONG, TimestampNTZType) => avroType.getLogicalType match {
+ // For backward compatibility, if the Avro type is Long and it is not
logical type
Review comment:
then can we at least update the comment? it's nothing about backward
compatibility, but to keep consistent with TS LTZ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
