LuciferYang commented on a change in pull request #33556:
URL: https://github.com/apache/spark/pull/33556#discussion_r680707160
##########
File path: core/benchmarks/DiskBlockObjectWriterCloseMethodBenchmark-results.txt
##########
@@ -0,0 +1,48 @@
+================================================================================================
+emptyDataBuffer
+================================================================================================
+
+OpenJDK 64-Bit Server VM 1.8.0_292-b10 on Mac OS X 11.4
+Apple M1
+emptyDataBuffer: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
+------------------------------------------------------------------------------------------------------------------------
+use close 0 0
0 0.1 11416.0 1.0X
+use revertPartialWritesAndClose 0 0
0 0.0 50000.0 0.2X
Review comment:
Although the else branch is entered only when `objectsWritten = = 0`,
there still seem to be some performance differences between the `close` and
`revertPartialWritesAndClose` method.
I run the bench with ssd，I don't know if there will be a more obvious
difference if HDD is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
