cloud-fan commented on a change in pull request #32355:
URL: https://github.com/apache/spark/pull/32355#discussion_r681125659
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -163,7 +164,13 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
// other choice.
case j @ ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, nonEquiCond,
left, right, hint) =>
def createBroadcastHashJoin(onlyLookingAtHint: Boolean) = {
- getBroadcastBuildSide(left, right, joinType, hint,
onlyLookingAtHint, conf).map {
+ val buildSide = getBroadcastBuildSide(
Review comment:
can we make it more general? I think we can also give a warning if
SMJ/SHJ hint is specified but the join has no join keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
