cloud-fan commented on a change in pull request #33382:
URL: https://github.com/apache/spark/pull/33382#discussion_r681127439
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HivePartitionFilteringSuite.scala
##########
@@ -110,12 +113,14 @@ class HivePartitionFilteringSuite(version: String)
client = init(true)
}
- test(s"getPartitionsByFilter returns all partitions when
$tryDirectSqlKey=false") {
- val client = init(false)
- val filteredPartitions =
client.getPartitionsByFilter(client.getTable("default", "test"),
- Seq(attr("ds") === 20170101))
+ test(s"getPartitionsByFilter returns all partitions when
$fallbackKey=false") {
+
withSQLConf(SQLConf.HIVE_METASTORE_PARTITION_PRUNING_FALLBACK_ON_EXCEPTION.key
-> "true") {
Review comment:
nit: we can use `fallbackKey` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
