otterc commented on a change in pull request #33613:
URL: https://github.com/apache/spark/pull/33613#discussion_r681395236
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -863,8 +884,8 @@ public void onComplete(String streamId) throws IOException {
if
(isStaleOrTooLate(appShuffleInfo.shuffles.get(partitionInfo.shuffleId),
partitionInfo.shuffleMergeId, partitionInfo.reduceId)) {
deferredBufs = null;
- throw new RuntimeException(String.format("Block %s is %s", streamId,
-
ErrorHandler.BlockPushErrorHandler.TOO_LATE_OR_STALE_BLOCK_PUSH_MESSAGE_SUFFIX));
+ throw new RuntimeException("Block " + streamId + " " +
Review comment:
There are still other instances in this class where we are formatting
the message of the RuntimeException with `String.format` but those haven't been
modified. Is it because they are quite infrequent? Still would be nice to have
this consistent in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
