Ngone51 commented on a change in pull request #33617:
URL: https://github.com/apache/spark/pull/33617#discussion_r681539916
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ErrorHandler.java
##########
@@ -64,6 +64,15 @@ default boolean shouldLogError(Throwable t) {
"received after merged shuffle is finalized or stale block push as
shuffle blocks of a"
+ " higher shuffleMergeId for the shuffle is being pushed";
+ /**
+ * String constant used for generating exception messages indicating the
attempt is not the
+ * latest attempt on the server side, and also for later checking such
exceptions on the
+ * client side. When we get a block push failure because of the too old
attempt, we will
+ * not retry pushing the block nor log the exception on the client side.
+ */
+ public static final String TOO_OLD_ATTEMPT_SUFFIX =
+ "received too old attempt message";
Review comment:
Spark usually uses 2 indentations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
