Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/497#discussion_r12340674
  
    --- Diff: 
graphx/src/main/scala/org/apache/spark/graphx/impl/Serializers.scala ---
    @@ -26,6 +26,33 @@ import org.apache.spark.serializer._
     import scala.language.existentials
     
     private[graphx]
    +class RoutingTableMessageSerializer extends Serializer with Serializable {
    +  override def newInstance(): SerializerInstance = new 
ShuffleSerializerInstance {
    +
    +    override def serializeStream(s: OutputStream) = new 
ShuffleSerializationStream(s) {
    +      def writeObject[T](t: T) = {
    +        val msg = t.asInstanceOf[RoutingTableMessage]
    +        writeVarLong(msg.vid, optimizePositive = false)
    +        writeUnsignedVarInt(msg.pid)
    +        // TODO: Write only the bottom two bits of msg.position
    +        s.write(msg.position)
    +        this
    +      }
    +    }
    +
    +    override def deserializeStream(s: InputStream) = new 
ShuffleDeserializationStream(s) {
    --- End diff --
    
    Add an explicit return type


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to