cxzl25 commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-892347756


   > Could we change [this 
line](https://github.com/apache/hive/blob/branch-2.3/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L1596)
 to `Hive threadLocalHive = Hive.getWithoutRegisterFns(sessionConf);`?
   
   [HIVE-17368](https://issues.apache.org/jira/browse/HIVE-17368) avoid 
creating a `threadLocalHive` in the `unCacheDataNucleusClassLoaders` method.
   
   
https://github.com/apache/hive/blob/branch-3.0/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L1772
   
   > It seems that this change makes hive.downloaded.resources.dir can not be 
removed.
   
   AFIAK, because `SessionState.start` is not used, the resources directory 
will not be created.
   Because SPARK-35286 avoids creating session dir, that is, it will not call 
`createSessionDirs`.
   ```java
     /**
      * Create dirs & session paths for this session:
      * 1. HDFS scratch dir
      * 2. Local scratch dir
      * 3. Local downloaded resource dir
      * 4. HDFS session path
      * 5. hold a lock file in HDFS session dir to indicate the it is in use
      * 6. Local session path
      * 7. HDFS temp table space
      * @param userName
      * @throws IOException
      */
     private void createSessionDirs(String userName) throws IOException {
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to