Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5913#discussion_r29726776
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -150,6 +150,26 @@ sealed trait Vector extends Serializable {
toDense
}
}
+
+ /**
+ * Find the index of a maximal element. Returns the first maximal
element in case of a tie.
+ * Returns -1 if vector has length 0.
+ */
+ private[spark] def findMax: Int = {
+ if (size == 0) {
+ 0
--- End diff --
`-1`
We can also save `if .... else`:
~~~scala
var maxIdx = -1
var maxValue = Double.NegativeInfinity
foreachActive { (idx, value) =>
...
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
