allisonwang-db commented on a change in pull request #33530:
URL: https://github.com/apache/spark/pull/33530#discussion_r682868967



##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -270,7 +271,7 @@ private[spark] class BlockManager(
     // Don't reject broadcast blocks since they may be stored during task exec 
and
     // don't need to be migrated.
     if (isDecommissioning() && !blockId.isBroadcast) {
-        throw new BlockSavedOnDecommissionedBlockManagerException(blockId)

Review comment:
       Good catch. Yes let's keep the original exception classes and avoid 
changing them during the grouping process. We can make separate PRs in the 
future to improve quality.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to