[GitHub] [spark] zheniantoushipashi commented on a change in pull request #33201: [SPARK-36005][SQL] The canCast method of type of char/varchar is modified to be consistent with StringType

Thu, 05 Aug 2021 01:29:13 -0700 


zheniantoushipashi commented on a change in pull request #33201:
URL: https://github.com/apache/spark/pull/33201#discussion_r683242315



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -54,38 +54,38 @@ object Cast {
 
     case (NullType, _) => true
 
-    case (_, StringType) => true
+    case (_, StringType | CharType(_) | VarcharType(_)) => true

Review comment:
       in my application codeļ¼Œ I bring this commit, and rebuid and test, all ut 
and end-to-end test is passed, I'm working on upgrading spark from 2.4.1 to 
3.1.1, which Kylin Enterprise Edition depends on   
   
   @cloud-fan 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to