venkata91 commented on a change in pull request #33644:
URL: https://github.com/apache/spark/pull/33644#discussion_r682991221
##########
File path: core/src/main/scala/org/apache/spark/rdd/RDD.scala
##########
@@ -1233,6 +1233,21 @@ abstract class RDD[T: ClassTag](
(i, iter) => iter.map((i % curNumPartitions, _))
}.foldByKey(zeroValue, new
HashPartitioner(curNumPartitions))(cleanCombOp).values
}
+ if (conf.get(ENABLE_EXECUTOR_TREE_AGGREGATE) &&
partiallyAggregated.partitions.length > 1) {
+ // define a new partitioner that results in only 1 partition
+ val constantPartitioner = new Partitioner {
+ override def numPartitions: Int = 1
+
+ override def getPartition(key: Any): Int = 0
+ }
+ // map the partially aggregated rdd into a key-value rdd
+ // do the computation in the single executor with one partition
+ // get the new RDD[U]
+ partiallyAggregated = partiallyAggregated
+ .map(v => (0.toByte, v))
+ .foldByKey(zeroValue, constantPartitioner)(cleanCombOp)
+ .values
+ }
val copiedZeroValue = Utils.clone(zeroValue,
sc.env.closureSerializer.newInstance())
Review comment:
wouldn't this submit another job after the `foldByKey` again on the
`fold` eventually to just return the only value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
