cloud-fan commented on a change in pull request #33624:
URL: https://github.com/apache/spark/pull/33624#discussion_r683913923
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala
##########
@@ -542,13 +524,17 @@ case class ApplyColumnarRulesAndInsertTransitions(
/**
* Inserts RowToColumnarExecs and ColumnarToRowExecs where needed.
*/
- private def insertTransitions(plan: SparkPlan): SparkPlan = {
- if (plan.supportsColumnar) {
+ private def insertTransitions(plan: SparkPlan, outputsColumnar: Boolean):
SparkPlan = {
+ if (outputsColumnar) {
+ // The tree feels kind of backwards
+ // This is the end of the columnar processing so go back to rows
Review comment:
oh, I'll remove this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
