cloud-fan commented on a change in pull request #33651:
URL: https://github.com/apache/spark/pull/33651#discussion_r683916185
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/LogicalQueryStage.scala
##########
@@ -54,4 +54,6 @@ case class LogicalQueryStage(
}
physicalStats.getOrElse(logicalPlan.stats)
}
+
+ override def maxRows: Option[Long] =
stats.rowCount.map(_.min(Long.MaxValue).toLong)
Review comment:
We should trust the existing framework. If the `maxRows` stats can be
wrong, then `EliminateLimits` is also wrong even without AQE.
I don't think we need to highlight `LogicalQueryStage` in the doc of
`EliminateLimits`. We just need to follow the existing framework and make sure
the `maxRows` is not under-estimated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
