Github user scwf commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5821#discussion_r29731959
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -438,6 +439,17 @@ object CombineFilters extends Rule[LogicalPlan] {
     }
     
     /**
    + * Combines Limit and Sort if possible, so it will be planed as TakeOrdered
    + * and won't do total ordering.
    + */
    +object CombineLimitSort extends Rule[LogicalPlan] {
    --- End diff --
    
    i think CombineLimitSort is more descriptive now, since this is single and 
special case of combine limit and sort. 
    we can rename it in future when there are more push down cases we add here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to