MaxGekk commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r684147182
##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,8 @@ SELECT INTERVAL '153722867280' MINUTE;
SELECT INTERVAL '-153722867280' MINUTE;
SELECT INTERVAL '54.775807' SECOND;
SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;
+SELECT INTERVAL '1' YEAR = INTERVAL '1' MONTH;
+SELECT INTERVAL '1-1' YEAR TO MONTH = INTERVAL '13' MONTH;
+SELECT INTERVAL '13' MONTH > INTERVAL '1' YEAR;
Review comment:
Could you add more tests:
- At least, every supported ANSI interval type should be tested
- More compare ops
- Negative, 0, positive intervals
- Negative tests
- Comparison of year-month with day-time intervals (should fail).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
