ueshin commented on a change in pull request #33634:
URL: https://github.com/apache/spark/pull/33634#discussion_r684327912
##########
File path: python/pyspark/pandas/tests/indexes/test_base.py
##########
@@ -1527,10 +1527,8 @@ def test_union(self):
almost=True,
)
+ # Bug in Index.union dropping duplicated values is fixed in pandas
1.3
if LooseVersion(pd.__version__) >= LooseVersion("1.3"):
Review comment:
Hmm, I'm afraid I'm against the change 6ed03e7.
It doesn't test with the actual pandas behavior we are following, so even if
pandas changes the behavior in the future, we won't know it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
