dongjoon-hyun commented on a change in pull request #33655:
URL: https://github.com/apache/spark/pull/33655#discussion_r684347752
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -480,6 +480,7 @@ object SQLConf {
.doc("(Deprecated since Spark 3.0)")
.version("1.6.0")
.bytesConf(ByteUnit.BYTE)
+ .checkValue(_ > 0, "advisoryPartitionSizeInBytes must be positive")
Review comment:
@cloud-fan . If we set negative values to `advisoryPartitionSizeInBytes`
explicitly, it will not fallback to here. If we want to say,
`advisoryPartitionSizeInBytes must be positive`, we should check both places,
shouldn't we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
