SaurabhChawla100 commented on a change in pull request #33679:
URL: https://github.com/apache/spark/pull/33679#discussion_r684924662
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ordering.scala
##########
@@ -97,13 +97,18 @@ object InterpretedOrdering {
object RowOrdering extends
CodeGeneratorWithInterpretedFallback[Seq[SortOrder], BaseOrdering] {
/**
- * Returns true iff the data type can be ordered (i.e. can be sorted).
+ * Returns true if the data type can be ordered (i.e. can be sorted).
*/
- def isOrderable(dataType: DataType): Boolean = dataType match {
+ def isOrderable(dataType: DataType,
Review comment:
@HyukjinKwon - Thanks for checking this PR. Yes we can wait for this PR
https://github.com/apache/spark/pull/32552. The fix in this will work with
group by, order by , partition by in window.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
