cloud-fan commented on a change in pull request #33666:
URL: https://github.com/apache/spark/pull/33666#discussion_r685777557
##########
File path: sql/core/src/test/resources/sql-tests/results/date.sql.out
##########
@@ -331,12 +331,20 @@ struct<date_add(DATE '2011-11-11', 1):date>
-- !query
-select date_add(timestamp_ltz'2011-11-11 12:12:12', 1),
date_add(timestamp_ntz'2011-11-11 12:12:12', 1)
+select date_add(timestamp_ltz'2011-11-11 12:12:12', 1)
+-- !query schema
+struct<date_add(TIMESTAMP '2011-11-11 12:12:12', 1):date>
+-- !query output
+2011-11-12
+
+
+-- !query
+select date_add(timestamp_ntz'2011-11-11 12:12:12', 1)
Review comment:
if `timestamp_ntz` becomes the default in the future, it's better to
support this query as well to not break anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
