LuciferYang commented on a change in pull request #33682:
URL: https://github.com/apache/spark/pull/33682#discussion_r686448268



##########
File path: 
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -29,7 +29,6 @@ import scala.collection.mutable.{ArrayBuffer, HashMap, 
HashSet, Queue}
 import scala.util.{Failure, Success}
 
 import io.netty.util.internal.OutOfDirectMemoryError
-import org.apache.commons.io.IOUtils

Review comment:
       ```
   @deprecated As of 2.6 deprecated without replacement. Please use the 
try-with-resources statement or handle
   suppressed exceptions manually.
   ```
   
   All our original logic is suppressing `IOException`, so I think we can reuse 
`JavaUtils. closeQuietly` directly If all modules can access it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to