gatorsmile commented on pull request #31517:
URL: https://github.com/apache/spark/pull/31517#issuecomment-896472030


   Sorry for my late review. 
   
   @LuciferYang Since it adds the new dependences, could you show us the 
benefits besides the one in the micro-benchmark? Yes, Caffeine is faster than 
Guava Cache from benchmarks, but does it affect our performance if it is not 
being used in any hot path? Maybe I am wrong, could you show me an example?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to