yaooqinn commented on a change in pull request #33706:
URL: https://github.com/apache/spark/pull/33706#discussion_r686696144
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
##########
@@ -68,13 +71,19 @@ private[sql] class JsonInferSchema(options: JSONOptions)
extends Serializable {
Some(inferField(parser))
}
} catch {
- case e @ (_: RuntimeException | _: JsonProcessingException) =>
parseMode match {
- case PermissiveMode =>
- Some(StructType(Seq(StructField(columnNameOfCorruptRecord,
StringType))))
- case DropMalformedMode =>
+ case e @ (_: RuntimeException | _: JsonProcessingException | _:
IOException) =>
+ if (ignoreCorruptFiles) {
+ logWarning(s"Skipped the corrupted file: $row", e)
Review comment:
here we use it for inferring schema, not all the content.
At avro side `org.apache.spark.sql.avro.AvroUtils#inferAvroSchemaFromFiles`,
we say
```
Skipped the footer in the corrupted file: ...
```
How about we print `Skipped inferring schema from the corrupted file: ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
