Ngone51 commented on a change in pull request #33617:
URL: https://github.com/apache/spark/pull/33617#discussion_r686803336
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ErrorHandler.java
##########
@@ -87,9 +87,11 @@ public boolean shouldRetryError(Throwable t) {
return false;
}
- // If the block is too late or stale block push, there is no need to
retry it
+ // If the block is too late or the invalid block push or the attempt is
not the latest one,
+ // there is no need to retry it
return !(t instanceof BlockPushNonFatalFailure &&
(((BlockPushNonFatalFailure) t).getReturnCode() == TOO_LATE_BLOCK_PUSH
||
+ ((BlockPushNonFatalFailure) t).getReturnCode() ==
TOO_OLD_ATTEMPT_PUSH ||
((BlockPushNonFatalFailure) t).getReturnCode() == STALE_BLOCK_PUSH));
Review comment:
Shall we make this a static method of `ReturnCode`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
