dongjoon-hyun commented on a change in pull request #33675:
URL: https://github.com/apache/spark/pull/33675#discussion_r686992270
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
##########
@@ -92,7 +101,9 @@ private[spark] object SparkKubernetesClientFactory extends
Logging {
.withRequestTimeout(clientType.requestTimeout(sparkConf))
.withConnectionTimeout(clientType.connectionTimeout(sparkConf))
.withTrustCerts(sparkConf.get(KUBERNETES_TRUST_CERTIFICATES))
- .withOption(oauthTokenValue) {
+ .withOption(oauthTokenProviderInstance) {
+ (provider, configBuilder) =>
configBuilder.withOauthTokenProvider(provider)
+ }.withOption(oauthTokenValue) {
Review comment:
Thank you for checking. In that case, the current situation may cause a
confusion to the Spark users. From Spark perspective, we have two options.
- Option A: We can revise the description of this new configuration about
that precedence.
- Option B: We can ignore
`spark.kubernetes.client.oauth.token.provider.class` when `oauthToken` exists
from Spark side.
Which one do you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
