c21 commented on a change in pull request #33711:
URL: https://github.com/apache/spark/pull/33711#discussion_r687173621
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/DisableUnnecessaryBucketedScan.scala
##########
@@ -120,7 +120,7 @@ object DisableUnnecessaryBucketedScan extends
Rule[SparkPlan] {
private def hasInterestingPartition(plan: SparkPlan): Boolean = {
plan.requiredChildDistribution.exists {
- case _: ClusteredDistribution | _: HashClusteredDistribution => true
+ case _: ClusteredDistribution | _: HashClusteredDistribution | AllTuples
=> true
Review comment:
For a query like below
```
SELECT SUM(id)
FROM t1
```
If table `t1` has more than 1 bucket (say 4 buckets), we can still disable
bucket scan, because scan will have 4 RDD partitions/tasks with bucketed scan,
and it does not satisfy single partition requirement from `AllTuples`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
