HeartSaVioR commented on a change in pull request #33708:
URL: https://github.com/apache/spark/pull/33708#discussion_r687253349
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
##########
@@ -642,9 +647,7 @@ case class SessionWindowStateStoreSaveExec(
// Assumption: watermark predicates must be non-empty if append mode
is allowed
case Some(Append) =>
allUpdatesTimeMs += timeTakenMs {
- val filteredIter = applyRemovingRowsOlderThanWatermark(iter,
Review comment:
No, what we filter out in read side is about input rows. Here we receive
all sessions including existing sessions in state even the sessions are
unchanged. We deal with eviction in later lines and provide output.
That said, if the logic filters out some sessions, it is a correctness
problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
