zsxwing commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-897405632
@ben-manes thanks for the context and building for the great project. > Does the current use of Caffeine have any negative effects? If it exists, we can revert this pr. @LuciferYang Caffeine is definitely an amazing and popular project. But when we decide whether we should add a library , especially a popular library, to Spark, we also need to think about the impact to the downstream libraries and Spark applications. As Caffeine is pretty popular, many downstream libraries and Spark users probably are using it. If Spark adds it to its classpath, it will force them to use the same Caffeine version as Spark. If someone would like to use a different Caffeine version, the work would be non trivial since they need to shade their Caffeine version. Do you have any examples that we can get Caffeine's benefits from hot path, so that we can use that to make the tradeoff? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
