c21 commented on a change in pull request #33711:
URL: https://github.com/apache/spark/pull/33711#discussion_r688028096
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/DisableUnnecessaryBucketedScan.scala
##########
@@ -120,7 +120,7 @@ object DisableUnnecessaryBucketedScan extends
Rule[SparkPlan] {
private def hasInterestingPartition(plan: SparkPlan): Boolean = {
plan.requiredChildDistribution.exists {
- case _: ClusteredDistribution | _: HashClusteredDistribution => true
+ case _: ClusteredDistribution | _: HashClusteredDistribution | AllTuples
=> true
Review comment:
@ulysses-you - this is a bug in `DisableUnnecessaryBucketedScan` itself.
In addition:
> Is it better that change the outpt partitioning in FileSourceScanExec to
UnknownPartitioning if the bucket is 1 ?
This will cause regression for some queries, e.g. the aggregation query in
https://github.com/apache/spark/pull/33711#discussion_r687173621. An extra
shuffle is needed before aggregation, if the output partitioning is changed
from `HashPartitioning(id, 1)` to `UnknownPartitioning`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
