viirya commented on a change in pull request #33695:
URL: https://github.com/apache/spark/pull/33695#discussion_r688049261
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetReadState.java
##########
@@ -45,21 +47,41 @@
/** Maximum definition level for the Parquet column */
final int maxDefinitionLevel;
+ /** Maximum repetition level for the Parquet column */
+ final int maxRepetitionLevel;
+
/** The current index over all rows within the column chunk. This is used to
check if the
* current row should be skipped by comparing against the row ranges. */
long rowId;
- /** The offset in the current batch to put the next value */
- int offset;
+ /** The offset to put new values into definition & repetition level vector */
+ int levelOffset;
+
+ /** The offset to put new values into value vector */
+ int valueOffset;
/** The remaining number of values to read in the current page */
int valuesToReadInPage;
- /** The remaining number of values to read in the current batch */
- int valuesToReadInBatch;
+ /** The remaining number of rows to read in the current batch */
+ int rowsToReadInBatch;
+
+ // The following are only used when reading repeated values
+
+ /** When processing repeated values, whether we've found the beginning of
the first list after the
+ * current batch. */
Review comment:
"after the current batch." or "in the current batch."?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
