mridulm commented on a change in pull request #33731:
URL: https://github.com/apache/spark/pull/33731#discussion_r688177759
##########
File path:
core/src/main/scala/org/apache/spark/storage/DiskBlockObjectWriter.scala
##########
@@ -65,7 +65,16 @@ private[spark] class DiskBlockObjectWriter(
}
def manualClose(): Unit = {
Review comment:
Ideally, we should handle this in `closeResources` - but it is fine here
as well, given this is not `close` but `manualClose` and we control the
semantics of it :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
