gengliangwang commented on a change in pull request #33615:
URL: https://github.com/apache/spark/pull/33615#discussion_r689062221
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -2097,86 +2097,87 @@ package object config {
private[spark] val PUSH_BASED_SHUFFLE_ENABLED =
ConfigBuilder("spark.shuffle.push.enabled")
- .doc("Set to 'true' to enable push-based shuffle on the client side and
this works in " +
+ .doc("Set to true to enable push-based shuffle on the client side and
this works in " +
"conjunction with the server side flag
spark.shuffle.server.mergedShuffleFileManagerImpl " +
"which needs to be set with the appropriate " +
"org.apache.spark.network.shuffle.MergedShuffleFileManager
implementation for push-based " +
"shuffle to be enabled")
- .version("3.1.0")
+ .version("3.2.0")
Review comment:
It seems that we have exposed this in 3.1.0(3.1.1) already:
https://github.com/apache/spark/blob/branch-3.1/core/src/main/scala/org/apache/spark/internal/config/package.scala
Why do we change the version here? The feature is not ready in 3.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
