ueshin commented on a change in pull request #33714:
URL: https://github.com/apache/spark/pull/33714#discussion_r689759473
##########
File path: python/pyspark/pandas/tests/test_dataframe.py
##########
@@ -5614,6 +5614,40 @@ def test_at_time(self):
with self.assertRaisesRegex(TypeError, "Index must be DatetimeIndex"):
psdf.at_time("0:15")
+ def test_combine_first(self):
Review comment:
Btw, the following tests should be in `test_ops_on_diff_frames.py`?
##########
File path: python/pyspark/pandas/tests/test_dataframe.py
##########
@@ -5614,6 +5614,40 @@ def test_at_time(self):
with self.assertRaisesRegex(TypeError, "Index must be DatetimeIndex"):
psdf.at_time("0:15")
+ def test_combine_first(self):
Review comment:
Could you also try with the DataFrames in the same anchor?
E.g.,:
```py
pdf = pd.DataFrame({("X", "A"): [None, 0], ("X", "B"): [4, None], ("Y",
"C"): [3, 3], ("Y", "B"): [1, 1]})
pdf1 = pdf["X"]
pdf2 = pdf["Y"]
psdf = ps.from_pandas(pdf)
psdf1 = psdf["X"]
psdf2 = psdf["Y"]
...
```
Hopefully the result can preserve the same anchor. I'm not sure whether we
can or not, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
