AngersZhuuuu commented on a change in pull request #33736:
URL: https://github.com/apache/spark/pull/33736#discussion_r690071365
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
##########
@@ -79,6 +79,17 @@ trait TPCDSBase extends SharedSparkSession with TPCDSSchema {
""".stripMargin)
}
+ def createTables(): Unit = {
Review comment:
> where else do we call this method?
Since PlanStabilitySuite extends TPCDSBase and the create table in
`beforeAll`, here we split `createTables`
then for TPCH suite we can only just create our needed table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
