Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5801#discussion_r29779387
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
    @@ -101,32 +103,84 @@ private[sql] class DefaultSource
       }
     }
     
    -private[sql] case class JSONRelation(
    -    path: String,
    -    samplingRatio: Double,
    +private[sql] class JSONRelation(
    +    // baseRDD needs to be created on scan and not when JSONRelation is
    +    // constructed, so we need a function (call by name) instead of a value
    +    baseRDD: => RDD[String],
    --- End diff --
    
    can you update the comment to document why it needs to be created on scan?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to