LuciferYang commented on a change in pull request #33748:
URL: https://github.com/apache/spark/pull/33748#discussion_r690878545
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -154,11 +155,17 @@ class OrcFileFormat
(file: PartitionedFile) => {
val conf = broadcastedConf.value.value
+ val metaCacheEnabled =
conf.getBoolean(SQLConf.FILE_META_CACHE_ENABLED.key, false)
Review comment:
It seems that there is no problem here. If `useFileMetaCacheList` config
is used, we can move the
```
val metaCacheEnabled = useFileMetaCacheList.toLowerCase(Locale.ROOT)
.split(",").map(_.trim).contains(shortName)
```
out of
```
(file: PartitionedFile) => {
}
```
to avoid do `split + contains` for each task
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
