Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5897#discussion_r29782858
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSetMethods.java ---
@@ -71,8 +72,11 @@ public static boolean isSet(Object baseObject, long
baseOffset, int index) {
* Returns {@code true} if any bit is set.
*/
public static boolean anySet(Object baseObject, long baseOffset, long
bitSetWidthInBytes) {
- for (int i = 0; i <= bitSetWidthInBytes; i++) {
- if (PlatformDependent.UNSAFE.getByte(baseObject, baseOffset + i) !=
0) {
+ assert bitSetWidthInBytes % SIZE_OF_LONG == 0;
+ int widthInLong = (int)(bitSetWidthInBytes / SIZE_OF_LONG);
--- End diff --
SIZE_OF_LONG is measured in bits, not bytes, so I don't think that this is
correct either.
Given the number of minor issues like this, can you please add a proper
unit test for this method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
