xinrong-databricks commented on a change in pull request #33714:
URL: https://github.com/apache/spark/pull/33714#discussion_r691687482



##########
File path: python/pyspark/pandas/tests/test_dataframe.py
##########
@@ -5614,6 +5614,40 @@ def test_at_time(self):
         with self.assertRaisesRegex(TypeError, "Index must be DatetimeIndex"):
             psdf.at_time("0:15")
 
+    def test_combine_first(self):

Review comment:
       Frames with the same anchor work with the current approach, but the 
anchor is lost afterward. I guess that's not acceptable. I will see if there is 
an optimized approach.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to