cloud-fan commented on a change in pull request #33673:
URL: https://github.com/apache/spark/pull/33673#discussion_r691756821
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NoSuchItemException.scala
##########
@@ -29,18 +29,24 @@ import org.apache.spark.sql.types.StructType
* Thrown by a catalog when an item cannot be found. The analyzer will rethrow
the exception
* as an [[org.apache.spark.sql.AnalysisException]] with the correct position
information.
*/
-class NoSuchDatabaseException(
- val db: String) extends NoSuchNamespaceException(s"Database '$db' not
found")
+case class NoSuchDatabaseException(db: String)
+ extends AnalysisException(s"Database '$db' not found")
Review comment:
I can't think of a better way. AFAIK it's an ill pattern to extend a
case class in Scala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
