huaxingao commented on a change in pull request #33650:
URL: https://github.com/apache/spark/pull/33650#discussion_r691811111
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala
##########
@@ -57,6 +64,27 @@ abstract class FileScanBuilder(
StructType(fields)
}
+ def pushFilters(partitionFilters: Seq[Expression], dataFilters:
Seq[Expression]): Unit = {
+ this.partitionFilters = partitionFilters
+ this.dataFilters = dataFilters
+ this.pushedDataFilters = pushDataFilters(dataFilters)
Review comment:
Actually, we don't need to have file data sources implementing
`SupportsPushDownFilters` any more. The purpose of `SupportsPushDownFilters` is
to push filters (in the format of `Sources.Filter`) to file source. Now in this
new `pushFilters(partitionFilters: Seq[Expression], dataFilters:
Seq[Expression])`, we have already pushed both the partition filters and data
filters to file source, so no need to implement `SupportsPushDownFilters` any
more to push the filters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
