cloud-fan commented on a change in pull request #32816:
URL: https://github.com/apache/spark/pull/32816#discussion_r691844920
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -111,13 +111,22 @@ case class AdaptiveSparkPlanExec(
DisableUnnecessaryBucketedScan
) ++ context.session.sessionState.queryStagePrepRules
+ // This list rules are applied between queryStagePreparationRules and
estimate physical plan cost
+ // so that we can support introduce extra shuffle
Review comment:
I'm thinking about a more efficient way that runs `EnsureRequirements`
only once
```
def queryStagePreparationRules(optimizeSkewJoin: Boolean) = {
val rules = Seq(
RemoveRedundantProjects,
OptimizeSkewedJoin,
...
)
if (optimizeSkewJoin) rules else rules.filterNot(_ != OptimizeSkewedJoin)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
